Skip to content

[PWGEM] PhotonMeson: Add task for event normalization on derived data - #17875

Merged
jokonig merged 1 commit into
AliceO2Group:masterfrom
jokonig:master
Sep 18, 2026
Merged

[PWGEM] PhotonMeson: Add task for event normalization on derived data#17875
jokonig merged 1 commit into
AliceO2Group:masterfrom
jokonig:master

Conversation

@jokonig

@jokonig jokonig commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator
  • If only events with a certain number of photons (or any other kind of selection) are stored in the derived data, the table "PMEvSelBits" in the event selection task can store the event selection bits. Hence, the number of selected events before the specific selection on the number of photons etc. can be retrieved.
  • This new task just loops over these event-selection bits and stores them in a histogram.
  • For future: Also store it as a function of multiplicity etc.

@github-actions github-actions Bot added pwgem photon Photon and neutral meson PAG label labels Sep 10, 2026
@github-actions

github-actions Bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@jokonig
jokonig marked this pull request as ready for review September 10, 2026 21:35
@alibuild

alibuild commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 681f61e at 2026-09-15 09:58:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 0 warnings.'
Found 5 errors and 0 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/cd18de5d4275378687aea11b601f93c2f64c4964/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/Tasks/eventNormalizationTask.cxx:25:1: error: included header TH1D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/eventNormalizationTask.cxx:38:45: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/eventNormalizationTask.cxx:60:10: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/eventNormalizationTask.cxx:61:21: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/eventNormalizationTask.cxx:75:3: error: no header providing "PROCESS_SWITCH" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera

vkucera commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

@jokonig Your PR introduces errors. Please fix them before merging.

@vkucera
vkucera marked this pull request as draft September 15, 2026 08:06
@dsekihat
dsekihat marked this pull request as ready for review September 16, 2026 15:47
@dsekihat

dsekihat commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

PR should not be marked as draft due to the optional checks.

@vkucera

vkucera commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

@dsekihat The PR introduces errors from the category that has already been cleaned up and therefore adds regressions which should not be merged, as we agreed.

@dsekihat

dsekihat commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

No. I didn't agree. Decision on merging PRs is taken by the code owners.

@vkucera

vkucera commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Decision on merging PRs is taken by the code owners.

Yes. And I am not preventing it. What is the problem?

@dsekihat

dsekihat commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

As I wrote above, you are not supposed to move PRs to draft due to the optional checks.

jokonig
[PWGEM] PhotonMeson: Add task for event normalization on derived data
c40d8f0 
- If only events with a certain number of photons (or any other kind of selection) are stored in the derived data, the table "PMEvSelBits" in the event selection task can store the event selection bits. Hence, the number of selected events before the specific selection on the number of photons etc. can be retrieved.
- This new task just loops over these event-selection bits and stores them in a histogram.
- For future: Also store it as a function of multiplicity etc.
@jokonig
jokonig enabled auto-merge (squash) September 18, 2026 12:06
alibuild
alibuild approved these changes Sep 18, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jokonig.

@vkucera

vkucera commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

@jokonig Please wait for the tests to finish before you enable merging, unless the PR is urgent.

@jokonig
jokonig merged commit 4e6f70e into AliceO2Group:master Sep 18, 2026
13 checks passed
@jokonig

jokonig commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @vkucera
there was only the mandatory o2 build remaining and I checked the code checker locally after fixing the issues you pointed out before. But next time I can also wait until all checks have passed!

@vkucera

vkucera commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Hi @vkucera there was only the mandatory o2 build remaining and I checked the code checker locally after fixing the issues you pointed out before. But next time I can also wait until all checks have passed!

Hi @jokonig , thanks a lot for checking locally. That works fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner
@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner
@amaringarcia amaringarcia Awaiting requested review from amaringarcia amaringarcia is a code owner
@reygers reygers Awaiting requested review from reygers reygers is a code owner

Assignees

No one assigned

Labels

photon Photon and neutral meson PAG label pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jokonig @alibuild @vkucera @dsekihat